On Mon, Feb 07, 2005 at 04:02:44PM -0800, Matthew Dharm wrote: > On Tue, Feb 08, 2005 at 12:19:19AM +0100, Andi Kleen wrote: > > Remove useless AMD 8111 EHCI USB 2.0 errata check. The BIOS disable it > > anyways > > when needed, and when not then the hardware works. This cleans up > > the EHCI driver a bit which shouldn't need to know about such Erratas. > > > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> > > This is not a valid assertion. The IBM 970FX Evaluation Platform (aka > Maple-D) has an 8111 but does _not_ have an x86 BIOS. So the device tree > is built from a normal PCI-scan (unlike x86 BIOS which passes an explicit > tree). That device tree therefore shows the device.
That sounds like a firmware bug then. Perhaps it would be better to fix the firmware than to add these workarounds to Linux code? > > The patch was actually constructed to account for this case and all > derivative designs of the 970FX technology. Just apparently nobody tested it because it didn't work at all and caused a oops at boot. Therefore this code cannot be too useful, otherwise all these 970FX users would have noticed the failure. BTW EHCI works, you just shouldn't use any USB 2.0 devices. But there are valid reasons in some cases to want to have EHCI even on a 8111, e.g. if you want to use the debug port. It's annoying to have to fight against such dumb code in the kernel then. -Andi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
