Re: [linux-usb] SMP hang in usb-uhci/usbcore in pre9-2

[Al Borchers]

Johannes Erdfelt wrote:

> Looking at the driver, why do you only use spin_lock? It's not
> safe for interrupts.
> 
> This may be causing the deadlocks you are seeing.

Originally I used spin_lock_irqsave, but it caused problems (its been a while
so I don't quite remember the details).  I meant to ask or check the code to
see if our serial converter would ever be called directly from an interrupt
--if the code is not called from an interrupt I should not need to use
spin_lock_irqsave, correct?  Is the callback function called directly
from an interrupt, or simply put on the task queue and called during idle
time?

I will go back to spin_lock_irqsave and see what effect that has now.

Thanks,
-- Al

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]