Greg KH wrote:
> Hm, I like a hack just as much as the next person but...
>
> I agree that this fixes the problem today, but something just doesn't feel
> good about relying on returning 256 from chars_in_buffer in accomplishing
> this.
I agree completely. Don't know why the magic 256 is hardcoded into n_tty.c;
its not appropriate for our USB serials drivers.
Using chars_in_buffer seems backward, anyway, since for that to give you a
meaningful idea of whether write will succeed or not you need to know how
big the buffer is. It seems like write_room would be the more appropriate
function to use, since that is independent of the buffer size.
n_tty.c only uses write_room in opost processing--maybe these two functions
were designed for different purposes. Hope the serial people can explain it
to us. Quick search of the mailing list archive for "chars_in_buffer",
"write_room", "WAKEUP_CHARS", and "n_tty.c" turned up nothing.
-- Al
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
