On Tue, Jan 28, 2014 at 4:38 PM, Phoebe Buckheister
<phoebe.buckheis...@itwm.fraunhofer.de> wrote:
> On Mon, 27 Jan 2014 22:27:35 +0400
> Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote:
>> Since you will be adding lots of rf212-specific operations later,
>> please duplicate _ops structure, so that you would have a set of rf230
>> operations and a set of rf212 operations.
>
> That requires some more changes to mac802154, since devices are
> allocated with a pointer to the ops struct they should use. I'm not
> currently sure how to do that nicely; simply writing to ->ops seems too
> hackish, and adding a function to ieee802154_dev to change the ops
> structure doesn't seem that much cleaner.

I'd suggest to update at86rf230_probe function to initialize and identify
hardware earlier and only after that to allocate an ieee802154 device.

Other suggestion would be to ask user to provide exact chip name
in the spi board data, however that seems sluggish to me.

-- 
With best wishes
Dmitry

------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable 
security intelligence. It gives you real-time visual feedback on key
security issues and trends.  Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to