On Tue, 22 Jan 2008 21:09:14 -0500 Jon Smirl <[EMAIL PROTECTED]> wrote:
>
> +static struct of_device_id mpc_i2c_of_match[] = {
(sfr winds up his broken record :-)) const, please.
> +#else
> +
> static int fsl_i2c_probe(struct platform_device *pdev)
While this code is still here, you should still explicitly include
<linux/platform.h>
> - fail_add:
> +fail_add:
If you are going to move labels, many people leave a single space in
front of them so that "diff -p" picks up the function name instead of the
label name.
> +void of_register_i2c_devices(struct i2c_adapter *adap, struct device_node
> *adap_node)
> + compatible = of_get_property(node, "compatible", &len);
You can specify NULL instead of &len since you don't use the returned value.
> + if (!compatible) {
> + printk(KERN_ERR "i2c-mpc.c: invalid entry, missing
> compatible attribute\n");
Some of these printk lines are a bit long.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp7cv0rEF5Zk.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
