> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:linuxppc-dev- > [EMAIL PROTECTED] On Behalf Of Segher Boessenkool > Sent: Friday, March 21, 2008 9:46 AM > To: Sergei Shtylyov > Cc: linuxppc-dev@ozlabs.org; John Linn > Subject: Re: [PATCH 2/3] [POWERPC] Xilinx: of_serial support for Xilinx uart16550. > > > The proposed use clearly would treat them as generic, since in the > > context of the Xilinx UART they're just not needed -- it's known > > beforehand and most probably fixed how/where the registers are mapped. > > There's just no need for such info in the device tree -- unless you're > > going to teach the *generic* driver to handle this specific (and > > possibly others alike) kind of a device. > > I was under the impression that the "xilinx uart" was just a 16550 (or > so) > with its registers wired up in a slightly unusual way. If it's a > completely > different device, of course you need a separate binding, and you might > not > want reg-shift properties etc. there.
It's a standard 16550, with registers in the standard order, but at offsets 3,7,11, etc. Steve _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
