On 08/11/2011 06:07 PM, Robin Holt wrote:
> Allow the p1010 processor to select the flexcan network driver.
> 
> Signed-off-by: Robin Holt <h...@sgi.com>
> Acked-by: Marc Kleine-Budde <m...@pengutronix.de>,
> Acked-by: Wolfgang Grandegger <w...@grandegger.com>,
> Cc: U Bhaskar-B22300 <b22...@freescale.com>
> Cc: socketcan-c...@lists.berlios.de,
> Cc: net...@vger.kernel.org,
> Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
> Cc: Kumar Gala <ga...@kernel.crashing.org>
> ---
>  arch/powerpc/boot/dts/p1010rdb.dts  |    8 ++++++++
>  arch/powerpc/platforms/85xx/Kconfig |    2 ++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/p1010rdb.dts 
> b/arch/powerpc/boot/dts/p1010rdb.dts
> index d6c669c..df89b60 100644
> --- a/arch/powerpc/boot/dts/p1010rdb.dts
> +++ b/arch/powerpc/boot/dts/p1010rdb.dts
> @@ -171,6 +171,14 @@
>                       };
>               };
>  
> +             can@1c000 {
> +                     clock-frequency = <0x0bebc1fc>;
> +             };


                        clock-frequency = <200000000>; // filled in by 
boot-loader

Is better readable and makes clear that the value is filled in by the
boot loader. Usually we specify "<0>" in that case but it will *not*
work with your board because U-Boot fills into the property "clock_freq"
the CCB-frequency, which is twice as much. This needs to be fixed.

> +             can1: can@1d000 {

What is the "can1:" good for?

> +                     clock-frequency = <0x0bebc1fc>;

See above.

Wolfgang.




>               usb@22000 {
>                       phy_type = "utmi";
>               };
> diff --git a/arch/powerpc/platforms/85xx/Kconfig 
> b/arch/powerpc/platforms/85xx/Kconfig
> index 498534c..c4304ae 100644
> --- a/arch/powerpc/platforms/85xx/Kconfig
> +++ b/arch/powerpc/platforms/85xx/Kconfig
> @@ -70,6 +70,8 @@ config MPC85xx_RDB
>  config P1010_RDB
>       bool "Freescale P1010RDB"
>       select DEFAULT_UIMAGE
> +     select HAVE_CAN_FLEXCAN if NET && CAN
> +     select PPC_CLOCK if CAN_FLEXCAN
>       help
>         This option enables support for the MPC85xx RDB (P1010 RDB) board
>  

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to