On Aug 11, 2011, at 11:18 AM, Marc Kleine-Budde wrote: > On 08/11/2011 06:07 PM, Robin Holt wrote: >> If our CAN device's device tree node has a clock-frequency property, >> then use that value for the can devices clock frequency. If not, fall >> back to asking the platform/mach code for the clock frequency associated >> with the flexcan device. > > nitpicking follows inline: > >> Signed-off-by: Robin Holt <h...@sgi.com> >> To: Kumar Gala <ga...@kernel.crashing.org> >> To: Wolfgang Grandegger <w...@grandegger.com>, >> To: Marc Kleine-Budde <m...@pengutronix.de>, >> To: U Bhaskar-B22300 <b22...@freescale.com> >> To: Scott Wood <scottw...@freescale.com> >> To: Grant Likely <grant.lik...@secretlab.ca> >> Cc: socketcan-c...@lists.berlios.de, >> Cc: net...@vger.kernel.org, >> Cc: PPC list <linuxppc-dev@lists.ozlabs.org> >> Cc: devicetree-disc...@lists.ozlabs.org >> --- >> .../devicetree/bindings/net/can/fsl-flexcan.txt | 2 + >> drivers/net/can/flexcan.c | 33 >> +++++++++++++++----- >> 2 files changed, 27 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >> index c78dcbb..a4382c7 100644 >> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >> @@ -11,6 +11,7 @@ Required properties: >> >> - reg : Offset and length of the register set for this device >> - interrupts : Interrupt tuple for this device >> +- clock-frequency : The oscillator frequency driving the flexcan device >> >> Example: >> >> @@ -19,4 +20,5 @@ Example: >> reg = <0x1c000 0x1000>; >> interrupts = <48 0x2>; >> interrupt-parent = <&mpic>; >> + clock-frequency = <0x0bebc1fc>; > > Does the device tree support dec coded integers? IMHO a frequency is > best expressed in decimal.
Yes it does, and agree that in the example a dec # might be better - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev