On Tue, Jan 19, 2010 at 9:23 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
>
>
> On Mon, Jan 18, 2010 at 10:48 AM, Jason Childs <
> obliv...@users.sourceforge.net> wrote:
>
>> Hi Ping,
>>
>> I'm attaching a tar.bz2 of 17 patches that capture the changes I've done
>> over the last three days. I started a git repository with the base
>> 0.8.5-9 source from sourceforge, so some of the patches will look
>> useless as I changed stuff along the way.
>>
>
>
> Since there is quite a bit there, I suggest breaking the submits to CVS
> into batches. I suggest doing the earlier kernel patches first just because
> they can be verified on both versions of X drivers right now. Probably we
> should save the patch that disables buttons (0011) until its discussed a
> little more.
>
> Here is my feedback on your kernel driver patches; all tested with current
> git of xf86-input-wacom (you can add Tested-By: me if you like). The
> comments are more geared towards Ping or whom ever will submit the patches
> as a feel good measure then to Jason.
>
> 0006-Kernel-Module-Fix-shared-features-buffer-corruption.patch
>
> Seems an important fix. I saw no issues in review or testing. I really
> like appending Touch/Pen to name. Makes output of dmesg that much more
> useful.
>
> 0002-Kernel-Module-Fixes-for-Bamboo-P-T-issues.patch
> 0005-Kernel-Module-Change-Bamboo-P-T-features-length.patch
>
> Code definitely reads better using correct packet size everywhere. My
> tablet worked before and after patch though. I know Jason said it helps
> certain USB hubs and maybe more. Can't see a place it would hurt other
> tablets (wrapped in if()'s for Bamboo P&T specific functions).
>
> Patch 0002 contains some obvious fixes in x/y values that look good.
>
> 0001-Input-wacom-Debian-patch-for-device-ids.patch
>
> No real comment on this one. It worked for me and I saw no issues. I'm
> not sure I understand background of why patch was written. I think the
> reason may be in mailing list archive but I didn't look.
>
> 0003-X-Driver-Default-Bamboo-P-T-Touch-to-Relative.patch
>
> OK, the only xdrv patch I'll commit on for now. :-) Its already in
> xf86-input-wacom so might as well get it in linuxwacom as well.
>
> Chris
>
Previously, I recommended committing patches 0001, 0002, 0003, 0005, and
0006.
Now, I've ported patch 0004 to xf86-input-wacom and tested it. I highly
recommend committing this patch. With 0003 and 0004 patch, it makes Bamboo
P&T touch pad fully usable out of the box. Once those are committed, we are
beginning to move on to bug fixes to already committed code, behavior
improvements, and driver cleanups.
Chris
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
