On 19 January 2017 at 09:37, Joe Savage <joe.sav...@arm.com> wrote: >> Is it a true very direct example of the concept, or more of a mini >> application ? >> >> We are trying to lift out of examples those things that are more >> complex mini apps to a new apps directory. >> One distinction is the requirement to use external traffic generation >> for example would likely make it a mini app, another is size, or the >> need to use many ODP features making it less clear as an example of a >> specific ODP concept, and more of an mini application example showing >> a networking use case. > > Well, originally it was supposed to be a direct example, but I think it may > have ballooned into a mini-application. Though it handles artificially > generated traffic, and is not intended to be a feature complete out of the > box solution for fragmentation and reassembly (it asserts on fragment overlap > or duplication, doesn't invoke cleanup on hitting memory limits, etc.), it's > more complex than a simple "look, you can reassemble fragments with ODP!" > solution. For instance, it's lock-free, which introduces some complexity in > itself. > > It's around 1900 lines in total, so make of that what you will. > > Joe
Ok, I would not stop it going in examples, better to have it in, especially if it can run self contained and thus contribute to regression testing easily. -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org │ Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
