Am Donnerstag, den 25.03.2010, 17:05 -0400 schrieb Kaleb:

> Sure, it's right here:
> 
>
> http://dev.unity-linux.org/projects/unitylinux/repository/revisions/4115/entry/packages/libfm/F/libfm.spec
>  

About which version are we talking now? The subject of the mail reads
0.1.9, but the spec says it's libfm-HEAD.tar.xz. If you are using a git
version, you should at least provide the git version in the spec, not
only gitdate.

Last but not least I suggest using
make install DESTDIR=$RPM_BUILD_ROOT
instead of %makeinstall.

BTW: You are not owning the directories
%{_datadir}/%{name}/
%{_datadir}/%{name}/ui/
%{_sysconfdir}/xdg/%{name}/
%{_libdir}/%{name}/
%{_includedir}/%{name} and 
%{_includedir}/%{name}/%{name} (new location in 0.1.9)
this means users will have a couple of empty folders after uninstalling
the package.

You might want to take a look at
http://cvs.fedoraproject.org/viewvc/rpms/libfm/devel/libfm.spec?view=markup
for reference.

Regards,
Christoph


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Lxde-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lxde-list

Reply via email to