-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 26/03/2010 00:37, Christoph Wickert ha scritto:
> Am Donnerstag, den 25.03.2010, 17:05 -0400 schrieb Kaleb:
>
>
>> Sure, it's right here:
>>
>>
>> http://dev.unity-linux.org/projects/unitylinux/repository/revisions/4115/entry/packages/libfm/F/libfm.spec
>>
>
> About which version are we talking now? The subject of the mail reads
> 0.1.9, but the spec says it's libfm-HEAD.tar.xz. If you are using a git
> version, you should at least provide the git version in the spec, not
> only gitdate.
>
> Last but not least I suggest using
> make install DESTDIR=$RPM_BUILD_ROOT
> instead of %makeinstall.
>
this is usually right, but i think it's up to distro packaging
standards.. suse for example don't care about it(on my i586):
anu...@linux-y9ev:~> rpm --eval %make_install
make install
DESTDIR=/home/anubis/src/rpm/BUILDROOT/%{name}-%{version}-%{release}.i386
anu...@linux-y9ev:~> rpm --eval %makeinstall
make
DESTDIR=/home/anubis/src/rpm/BUILDROOT/%{name}-%{version}-%{release}.i386
install
that can may be the reason for your problem, so follow cwickert suggestion
> BTW: You are not owning the directories
> %{_datadir}/%{name}/
> %{_datadir}/%{name}/ui/
> %{_sysconfdir}/xdg/%{name}/
> %{_libdir}/%{name}/
> %{_includedir}/%{name} and
> %{_includedir}/%{name}/%{name} (new location in 0.1.9)
> this means users will have a couple of empty folders after uninstalling
> the package.
>
> You might want to take a look at
> http://cvs.fedoraproject.org/viewvc/rpms/libfm/devel/libfm.spec?view=markup
> for reference.
>
> Regards,
> Christoph
>
>
other things i don't like are empty %pre %post %preun %postun
you need at least to call ldconfig
Andrea
- --
- ------------------------------------------
Andrea Florio
QSI International School of Brindisi Sys Admin
CISCO CCNA Certified
openSUSE-Education Administrator
openSUSE Official Member (anubisg1)
Email: [email protected]
Packman Packaging Team
Email: [email protected]
Web: http://packman.links2linux.org/
Cell: +39-328-7365667
- ------------------------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/
iEYEARECAAYFAkur+m8ACgkQyCZT87TFPugO1wCgt5sit5mtvmzv/+o4FWVllM4t
HrsAn2bZ65ju2JgWu6CRVC4tOuY9OhtB
=C0SE
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Lxde-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lxde-list
