Uwe Stöhr wrote:
>> Your patch doesn't fix the bugs and it gives out e.g. "\{\}" (always both commands).

> Yes, that's the point. They will see all options at the same time before pressing "Insert". You > think the user needs a SMALL info, I think otherwise that the user should need the full info. The > small info is already visible in the tooltips.

Ah OK that was your intention. Hmm, I still don't think that the users needs the full info. Note that most of our users don't know LaTeX and those who knows it also know that a delimiter has the code in the form \left[ \right].

Note that my patch shows the LFUN argument not the LateX code, so it won't show the \left and \right. For example it will show:
{ }
{ Vert
bigl \{ bigr \Vert

I think it is useful to teach the user about the LFUNs. So it is not strictly about LateX; I should probably rename the different variables in consequence.

What do others think?


>> Your patch looks from the structure similar to mine, so I propose that I committ my patch as >> it fixes two real bugs. You can then add the \big stuff to this as this is an enhancement.
 >>    OK?

> Well, my patch do a bunch of clean-up at the same time and do a bit more like correctly update the > label for any user action (with the size combo, etc). Besides, your patch is a bit wrong because
 > it updates the label on each user click.

Why is this wrong? This doesn't cost anythingbut assures that the label is always correct.

My patch ensures that without creating those two additional slots (on_XXX_clicked).

Anyway, there is no point in discussing this further. If you really insist that your patch is better, put it in ;-). I don't mind very much.

Abdel.

Reply via email to