Dov Feldstern wrote:
Dov Feldstern wrote:
So, to sum up: the patch attached at
http://permalink.gmane.org/gmane.editors.lyx.devel/89376 together with
the patch attached here solve bug 1820 completely.
------------------------------------------------------------------------
Index: src/insets/InsetFootlike.h
===================================================================
--- src/insets/InsetFootlike.h (revision 19014)
+++ src/insets/InsetFootlike.h (working copy)
@@ -37,7 +37,7 @@
/** returns true if, when outputing LaTeX, font changes should
be closed before generating this inset. This is needed for
insets that may contain several paragraphs */
- bool noFontChange() const { return true; }
+ bool noFontChange() const { return false; }
};
Georg wrote about this (in bugzilla) as follows:
"This second part is probably a file format change (is it really needed
for all footlike insets?)."
My response:
Regarding whether or not this is necessary for all footlike insets: I
don't know. I've run into it for footnotes, but I think it should be
fixed for all footlike insets; I'm not sure if it's ever right, for that
matter. Do you know why this whole font-change mechanism was originally
added?
Would changing the patch to deal only with footnote and not footlike
change the question of this being a format change?
Regarding the format change: why is this a format change? I mean, yes,
in some cases the output of a given LyX file will change --- but I
*want* that to happen, because currently the output is wrong. If the
output before the patch is correct, then I think that with the patch
perhaps the generated latex may be slightly different, but the output
will remain the same. But the best thing would be if we could find
examples where this does actually cause a change in the output, then
we'll be able to deal with it. I've tried this on various files I have,
some of them with pretty complex font/language transitions, and they all
seem to be okay with these patches (i.e., the output is no different).
Dov
