Am 01.11.2010 18:19, schrieb Abdelrazak Younes:

Did I respond?

Not yet ;-)

The problem in #6997 is not a general issue, it is just a problem with the 
table dialog because we
don't read the full table parameters each time we move. So that is a bug and it 
is fixable. But as
Juergen said elsewhere this is difficult to solve because the table parameters 
are difficult to
localize, unlike InsetParms based dialog for example.

The problem is that the immediate apply option also applies when switching to another table. If this cannot be fixed easily I can sanitize the few cases where this leads to problems like switching from/to longtable and normal table (the one I described in the bug report). But before I start working on that I wanted to hear your opinion if there is another solution.

>> I committed the multirow feature before the Apply scheme was introduced and 
are disappointed
>> that you see me guilty that multirow doesn't work yet perfectly with this 
scheme.
>
> Here we are again Uwe... Your code was full of bugs or ready to disclose bugs 
and approximations,
> if it worked for you it was most likely by chance; without the work or Edwin, 
myself and others I
> guess it would have been reverted already. I really appreciate your 
documentation work Uwe but if
> you want to code, pretty please accept the responsibilities that comes with 
coding.

The multirow feature was a collaboration with Edwin. After getting it basically working I put it in to work on the feature on SVN for better collaboration (and as an alpha release was far away). I also set up a Wiki page for remaining issues to be solved for LyX 2.0. That others contribute was the plan and is my understanding of collaborative work. The new Apply/OK scheme was introduced after multirow support and it force us to rewrite the logic of the tabular dialog (e.g. introducing a set/unset action for every feature). This is no problem as the Apply/OK scheme was overdue since a long time and I'm happy that we have it. I was only a bit upset that Jürgen blamed the multirow feature for things that affect all features due to the Apply/OK scheme. That was all I wanted to say. That misunderstanding has already been resolved. You are not to blame and I only requested your help in the last mails in this thread. In the meantime I fixed hopefully all tabular dialog regressions and also all bugs related to multirow.

>> It seems that we have a general problem of getting the code stabilized. 
Wouldn't it therefore be
>> better to postpone things like the migration of dialogs to InsetParamsDialog 
until the current
>> dialog issues are sorted out?
>
> Oh, I am only trying to offer a consistent look&feel for LyX-2.0, that's all. But I don't think I > destabilize the code a lot... At least I know I can fix things in case I break them.

Then everything is fine. However I'm not sure if you manage to migrate all dialogs for LyX 2.0 or if we need to extend the release until the migration is done and all dialogs are tested. This should be discussed with Pavel.

thanks and regards
Uwe

Reply via email to