Le 23/10/2016 à 23:20, Uwe Stöhr a écrit :
commit a36706c3ffe9570588962a5ad3206d57e63ffcfd Author: Guillaume Munch <g...@lyx.org> Date: Sun Aug 28 21:57:17 2016 +0100Better title for ViewSourceSorry for being quite rude here: I am strictly opposed to these changes. LyX 2.2.x are bugfix releases. If the developers agree also some new features can go in. But these string changes are completely unnecessary in a bugfix release. The documentation is for all 2.2.x releases, as their title says. Unless bugs are fixed, there is no reason to change menu names. The consequence is that the docs of 2.2.x would differ for every release in a way that new users don't find the appropriate menu name. I can also not find a discussion where we made a decision to rename menu names without fixing a bug in a bugfix release. Therefore please revert these renamings. In general, what is the benefit of renaming "Source Pane|S" to "Code Preview Pane|P" ? I cannot see any advantage other than a lot of works to update the docs and the Wiki pages. Moreover, this changes the accelerator key. So you force users to learn a new one one an unchanged feature. Source is the Code. So what? thanks and regards
Hi Uwe, You are not being rude at all, in fact you are quite polite. And it is not too late to re-open an old discussion given that nothing has been released yet. First, surely you do not mean to revert the entire commit. The main purpose of the patch is to change the title of GuiViewSource to "LaTeX (pdflatex) preview", "LyXHTML preview", etc. The default title "Code Preview" does not appear in practice. I think you are mainly referring to the change in the menu name. During the discussions, I saw some confusion about the meaning of "source" and "code", and you even say that they mean the same to you. This is not true, and this change is meant for people who make the distinction. You say that it does not fix a bug, but I already explained that the former name introduced the confusion that LyX is a LaTeX editor. Maybe I was not clear enough, I am really concrete here: I saw new users (coming from LaTeX) focusing on GuiViewSource, trying hard to "edit" the ViewSourceWidget, thinking it was really the source, and ending up very disappointed. I have to admit that I was careless about changing the accelerator. I understand your point. I think that the best solution instead is to have "Code Preview Pane|S" as a reminiscence of the former name (just like GuiViewSource is going to remain GuiViewSource). I am ready to have this cosmetic discrepancy to fix such an issue. I can revert the menu name to "Source Pane" in 2.2.x for the documentation reasons you gave. I can also revert it in master if the majority wants it. But I hope that my explanation reassured you. Guillaume
