Am 24.10.2016 um 00:38 schrieb Guillaume Munch:
You are not being rude at all, in fact you are quite polite.
OK. I felt I was rude. I thought about it and began to update the docs when I realized what an impact these renaming have. Then I searched the Wiki and googled around. The source code window is referenced all over the place a lot. So changing this produces a lot of work for me, breaks the idea that the docs for LyX 2.2.x are valid for all 2.2 releases (except bugfixes of course) and finally I didn't see a benefit for the renaming at all.
So if you think the changed name is an improvement and the others agree, I am fine with this change in master but not for branch.
First, surely you do not mean to revert the entire commit. The main purpose of the patch is to change the title of GuiViewSource to "LaTeX (pdflatex) preview", "LyXHTML preview", etc. The default title "Code Preview" does not appear in practice. I think you are mainly referring to the change in the menu name.
Exactly. The window title is not the problem, but the menu name should stay.
I think that the best solution instead is to have "Code Preview Pane|S" as a reminiscence of the former name
I opt to change the accelerator of the name is changed. Otherwise 2 years later it will be confusing.
I can revert the menu name to "Source Pane" in 2.2.x for the documentation reasons you gave.
Please do so.
I can also revert it in master if the majority wants it. But I hope that my explanation reassured you.
If your experience is that the new name helps users, it is OK, I mean many things I do here are also driven from user feedback and are perhaps sometimes hard to understand by developers. For me user feedback is very important. So +1 from me. I don't know if there was already a vote. if not, I suggest to do one because this menu is used quite often and better to decide now than later in the RC cycle.
regards Uwe
