I'm about to commit a patch to update the KDE frontend
to MVC for everything, whilst doing it I came across some things :
1) Warning :
diff -u -r1.3 ButtonController.h
--- src/frontends/controllers/ButtonController.h 2001/03/30 16:42:54 1.3
+++ src/frontends/controllers/ButtonController.h 2001/03/30 19:46:52
@@ -62,7 +62,7 @@
template <class Button, class Widget>
GuiBC<Button, Widget>::GuiBC(string const & cancel, string const & close)
: ButtonControllerBase(cancel, close)
- , okay_(0), apply_(0), cancel_(0), undo_all_(0)
+ , okay_(0), apply_(0), undo_all_(0), cancel_(0)
{}
2) Can we possibly rename the "UndoAll" stuff to "Restore" ? After all, that's what
the button is called, and also better reflects the associated action IMHO
3) Segfault: worryingly this might be a kernel thing. If you do tabcreate->OK, then
tabcreate->OK
again, *boom* :/
4) the VCLog controller is all wrong, the getLogFile method actually creates a log file
via the VC commands. This *must* be done only at the time the dialog is opened (each
time)
and also, we need to unlink the file once the dialog has been populated.
5) Angus, is there a good reason why FormBase for xforms doesn't have bc().refresh() in
its show() function ? Currently you have bc().refresh() in each build() method for
every dialog ...
6) is there any chance we can rename ControlButton -> ControlButtons ? I don't have a
very good
reason for this, but Qt kindly has "ControlButton" as a global enum value. It's getting
really difficult to order the headers in kde/ correctly to avoid this braindamage, so
this would
make things a lot easier on me ... I know this isn't a very good reason for a change,
but I can't
see it would cause harm either
7) I find it a bit weird that I call a method "valid(bool)" whenever e.g. a user types
another character
in a line edit widget. Can we add another method mutated(bool) or changed(bool)
possibly ? This would
make at least the KDE frontend code a lot clearer IMHO
thanks
john
--
"You see things; and you say `Why?' But I dream things that never
were; and I say `Why not?'"
- George Bernard Shaw
