On Monday 02 April 2001 14:12, John Levon wrote:
> I'm about to commit a patch to update the KDE frontend
> to MVC for everything, whilst doing it I came across some things :
>
> 1) Warning :
> - , okay_(0), apply_(0), cancel_(0), undo_all_(0)
> + , okay_(0), apply_(0), undo_all_(0), cancel_(0)
Fixed in my source.
> 2) Can we possibly rename the "UndoAll" stuff to "Restore" ?
> After all, that's what the button is called, and also better reflects
> the associated action IMHO
Sure.
> 4) the VCLog controller is all wrong, the getLogFile method
> actually creates a log file via the VC commands. This *must*
> be done only at the time the dialog is opened (each time)
> and also, we need to unlink the file once the dialog has been populated.
Patch please ;-)
> 5) Angus, is there a good reason why FormBase for xforms doesn't
> have bc().refresh() in its show() function ? Currently you have
> bc().refresh() in each build() method for every dialog ...
No reason. Will do. Thank you for pointing this out.
> 6) is there any chance we can rename ControlButton -> ControlButtons ?
> I don't have a very good reason for this, but Qt kindly has "ControlButton"
> as a global enum value. It's getting really difficult to order the headers
> in kde/ correctly to avoid this braindamage, so this would make things
> a lot easier on me ... I know this isn't a very good reason for a change,
> but I can't see it would cause harm either
Will do. What a nice guy I am!
> 7) I find it a bit weird that I call a method "valid(bool)" whenever
> e.g. a user types another character in a line edit widget. Can we
> add another method mutated(bool) or changed(bool) possibly ?
> This would make at least the KDE frontend code a lot clearer IMHO
The name reflects the original function. The function has changed, so why not
the name.
Why don't you submit a patch for all this? I'm a bit busy this week.
A
