Andre Poenitz wrote: > Put it in and add a "#warning look here".
Done. >> The fact is that it's kind of dumb to try to acess the insettext's >> coordinates when it hasn't been drawn before: the user surely didn't >> intended that when clicking (the inset wasn't visible). It seems cleaner >> to me not to do it. > > Right. > >> Otherwise, we should ascertain that we have coordinates before (i.e. an >> update has been called) before calling LyXText::edit(x,y)... ugly. > > Or put some 'sensible' value there, i.e. LCursor::getPos() or similae Put a sensible value where? The problem is that LyXText::edit(x,y) need row/column coordinates information AFAICT... >> Unrelated1: triple click fails because LyXText::dispatch takes a cur >> argument but the 95% of it uses the real cursor. Smells fishy. > > The mouse stuff is not IU'ed yet. As a first approximation, everybody > should use the 'cur' argument, not 'cursor()'. Humm.. if we are doing such a tedious change, I propose to pass around a PitPosPair or CursorSlice instead of a full cursor... >> Unrelated2: MOUSE_PRESS opens a collapsable. MOUSE_RELEASE closes it. >> Guess the outcome. > > No need to guess. I've seen it yesterday evening. I was, however, happy > not to see it crash ;-) me too, it's kind of funny. (you can always move the cursor out of the button before releasing)... ;-) Alfredo
