Georg Baum <[EMAIL PROTECTED]> writes: > > Enrico Forestieri wrote: > > > The attached patch fixes the bug reported here: > > http://thread.gmane.org/gmane.editors.lyx.general/29227 > > > > In my intention this is the first of a series of patches aimed at > > polishing the Cygwin target, which I think is lagging behind. Please, tell > > me if this ok with you. I have no problem in maintaining the Cygwin target > > but my time is limited so I cannot guarantee a continuous commitment. I > > will do it time permitting. There should be no big problems, as I think > > the Cygwin users will not be more than those I can count with only one of > > my hands > > This patch looks good. I don't like the other one, because the code in > filetools.C is more complicated, and in this one it is more clear because > of cygwin_path_fix().
Really? I had thought the second one was more cleaner. Actually I had to figure out that when latex_path() is called for generating the argument of [EMAIL PROTECTED] it is assumed that a trailing / is present, and the second patch makes this clear not only for cygwin. On the other hand, external_path() is almost a no-op for the other OSes, so I don't it is such an overhead. So, what shall I use? > > Do you prefer that I file this one on bugzilla? > > I think it is there already: http://bugzilla.lyx.org/show_bug.cgi?id=2409 Or > do you fix something else? Funny, it was not there when I started working on the bug ;-) -- Enrico
