Georg Baum <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes wrote:
|
| > Georg Baum wrote:
| >> Yes. You store now the data twice, and it is not synchronised.
| >
| > If you mean data_ and QLyXKeySym, it was like this before, I am just
| > mapping functionalities with the old code. Port first, cleanup second.
| > If you mean argument and data_, then no, nothing is stored in arument
| > anymore.
|
| Yes, I mean argument and data_. Maybe nothing is stored for that particular
| lfun in argument anymore, but others do still use argument.
| You did not change getArg(), and you also forgot to adjust operator==. Adhoc
| changes like that are calling for bugs.
|
| >> Wait a bit, I am currently compiling an alternative.
|
| Here is the patch. The interesting bit is at the beginning: I added
| conversion functions from and to utf8 to docstring.h, and some comparison
| operators for ASCII strings.
Why cannot the converson functions be allowd to stay in one place?
(unicode.Ch)
After all we are not supposed to use them all the time.
| Then I changed the type of FuncRequest::argument to docstring, made it
| private (as it always should have been) and added an accessor.
| Then I added a lot of lyx::to_utf8() to fix the compile errors. Of course we
| do now have a lot more conversions than before, but these will either go
| away when more strings are converted to docstring, or can be changed to
| lyx::to_ascii() when we know that only ascii contents is stored.
Why/Where do we need to convert _to_ utf8?
| I will put this in tomorrow unless I get objections.
I'll look it over later tonight.
--
Lgb
