Hello all, Just jumping in as I'm the committer of this pull request. Is something else expected from the committer after the review has been done and then completed ? Would it be easier for the reviewer that the comitter rebase the pull request branch on top of master upon rework after the review ?
David On Mon, Nov 14, 2016 at 6:39 PM, Rainer Müller <rai...@macports.org> wrote: > On 2016-11-14 18:24, Eric A. Borisch wrote: > > Additionally, this PR also has changes requested by another committer, > > and acted upon (source of the second commit) by the requestor in the > > pull request. If I were to push the "Rebase and merge", should I first > > "Dismiss review" with "Requested changes made" as the reason? > > I am not sure if it would make a difference. There should be no > restrictions configured that would prevent a merge despite requested > changes, so either way should be fine if you checked that the changes > were fixed. > > To resolve this, I just approved the changes I requested. :-) > > Rainer >
