On 2016-11-14 18:24, Eric A. Borisch wrote:
> Additionally, this PR also has changes requested by another committer,
> and acted upon (source of the second commit) by the requestor in the
> pull request. If I were to push the "Rebase and merge", should I first
> "Dismiss review" with "Requested changes made" as the reason?

I am not sure if it would make a difference. There should be no
restrictions configured that would prevent a merge despite requested
changes, so either way should be fine if you checked that the changes
were fixed.

To resolve this, I just approved the changes I requested. :-)

Rainer

Reply via email to