On Mon, Feb 15, 2010 at 1:09 AM, Robin Anil <robin.a...@gmail.com> wrote: > If its A. I have a few patches ready to commit like the static qualifier > fix. I really need you guys to be on board on this. We just cant leave it at > this discussion. > > If its B. I will do the revert. But would have to patch some commits. > > If A sounds reasonable. Its easier to go forward than go back. I will not be > making any more changes at this scale. except bunch of classes from time to > time.
I think A sounds reasonable, given a patch for MAHOUT-291 that isn't as extensive, but I can't really comment on the potential for breaking other patches here. I would say that the people with that sort of time invested really should have the final say. Would it make sense for those with outstanding patches to apply 291 and then attempt to apply their patches to determine the extent of breakage? To be honest, anyone can do it really. If someone wants to post some jira issue references for patches that need to be tested I can mess around with trying to apply them this evening. Drew
