On Mon, Mar 18, 2019, at 1:04 AM, Christian Ehrhardt wrote: > On Fri, Mar 15, 2019 at 10:19 AM Jonas Smedegaard <d...@jones.dk> wrote: > > > > Quoting Christian Ehrhardt (2019-03-15 06:39:08) > > > On Fri, Mar 15, 2019 at 12:08 AM Abhilash Raj <maxk...@asynchronous.in> > > > wrote: > > > > On Thu, Mar 14, 2019, at 1:42 PM, Jonas Meurer wrote: > > > > Christian Ehrhardt: > > > > > I was evaluating the Dependencies of mailman3 in Ubuntu and I was > > > > > wondering if I could cut them down a bit. One thing that got my > > > > > attention is the dependency from mailman3-web [1] to nodejs for > > > > > less [2] and ruby-sass [3]. > > > > > > > > > > I was wondering if we could by default not install > > > > > node-less/ruby-sass and what exactly that would imply. > > > > less is a reinvention of sass: It is often adaptable to sass with a > > simple patch. > > > > Original sass processor was ruby-sass, but nowadays a better processor > > is sassc. Or if you want to integrated processing with Python then > > python3-libsass which uses same core library for its processing. > > > > I have not looked closely on mailman3, but I highly doubt there is a > > real need for dynamic processing of less/sass during runtime. > > Yeah I doubt that as well. > In the meantime I also found [1] which seems to have come to the same > conclusion for the majority of default setups. > For upstream to disable it by default it was mentioned that there is a > need for a customize kit which seems fine [1]. > > There is a further argument to disable the live compressors, at least > as I read COMPRESS_OFFLINE that seems helpful for production setups > anyway to speed up and safe CPU load. > > So while upstream waits until a "customize kit" exists to switch > defaults, as a downstream like Debian/Ubuntu I wonder if we already > could: > - drop sass/less compilers to a suggest > - disable the live compression in the default config that we ship > - keep the config commented-out to make it easy for admins that want > to enable it later > - pre-compress at build time and enable compress_offline for speed > - maybe call `django_admin compress` [3][4] or similar at build time? > - having sass/less as build dependencies seems much safer than > pulling it in at runtime +1 from me. It totally makes sense for any Mailman package to pre-compress the static files and not depend on any of those compilers.
Upstream doesn't declare any dependencies on sass or less compilers, since there is no way to do so, I don't think there is need to change anything except settings.py. > > @Jonas M.: what do you think about [2] (again maybe after Buster)? > Sorry to not know more of this yet, but I hope suggesting what I think > might work helps to get us the right way. > > [1]: > https://lists.mailman3.org/archives/list/mailman-us...@mailman3.org/thread/ACJDCHETCXHB2XOHH7PUMJ7RWNA5EJU4/ > [2]: > https://salsa.debian.org/paelzer-guest/mailman-suite/commits/make-sass-less-compilers-suggests > [3]: > https://django-compressor.readthedocs.io/en/latest/usage/#offline-compression > [4]: https://gitlab.com/mailman/django-mailman3/issues/17#note_81807465 > > > - Jonas > > > > -- > > * Jonas Smedegaard - idealist & Internet-arkitekt > > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > > > [x] quote me freely [ ] ask before reusing [ ] keep private > > -----BEGIN PGP SIGNATURE----- > > > > iQIzBAABCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAlyLbfwACgkQLHwxRsGg > > ASHlqw//Vkkke6aulFYeLkq7vQOIt08j+DMMDBpJ/vXapwtQJ2WbWEYsHbbFv75v > > k80SILudsOyGMwQ0HKRGqDmhJw2Voi9mWoV2fBQeCQn5w/G9N2Ddw8hAMrzGsLxO > > C2FOV8Db0irJ6FS6AO0YQpAselKnnX387AvyWBCpVcWWuydf46pMkPpYajVJTvZg > > UZxtBh1epmv/VdQlw2OeLrV+bZJWfjULjr1qFPYdqFnEUnOA2cC44RMagxSV7kNh > > JmCc7DvL/VjX/dkPHJCW/VvRrvfxzOR4bimVr7BeuvcjNljlUnKhRwP+PQZt80gp > > CbOoVCeEOFJuHwqTlvasUpxo/aSZZPFeF8aQBtdyzefEx9QjjGwx8bYQFn+Zo0CX > > TVsB7qWyCwMZIR0DP5+A8ityXQb+FwOTXjySMzO+Z/rA9+h1PHZrK+WJMB0O9z5r > > hWYDk3jGSJIkwL+AemE06gUPuSaXZWhzoduI2Mbzs8a20qhrW08Ij338RVGalyhC > > QHJT4JoI3bXylaK+IEpH9xxUEW0i8gOge32dBFiqg9/dGFm06Tf3z8dUuBFyXgG3 > > BsNJaO6Cn3ghfNS/OfNN04nPS+luPqPQ1r9yZMztrIqwv8oOWyVj1YQpKW1vRN/v > > BK/2IpBA+6O3OE2X4RCW8pouwPmsSgMmXpIsuFE61dox/8tOPmE= > > =490O > > -----END PGP SIGNATURE----- > > > > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > -- thanks, Abhilash Raj (maxking) _______________________________________________ Mailman-Developers mailing list -- mailman-developers@python.org To unsubscribe send an email to mailman-developers-le...@python.org https://mail.python.org/mailman3/lists/mailman-developers.python.org/ Mailman FAQ: https://wiki.list.org/x/AgA3 Security Policy: https://wiki.list.org/x/QIA9
