At 05:35 PM 8/17/2006, Christopher Faylor wrote: >On Thu, Aug 17, 2006 at 05:11:19PM -0400, William A. Hoffman wrote: >>I obviously care that the patch gets done. What I do not care about is >>the style of the code in make. The issue here is should sh_chars_sh be >>directly referenced or not. I think it should not, Chris things it >>should. It really is a matter of taste, and something for a make >>maintainer to choose. I just don't want to react to every suggestion >>with a new patch. > >Again, I don't think this is a matter of taste. I believe that you are >introducing a real change in behavior, i.e., the use of sh_chars_sh was >deliberate.
You are right, it was not a style or taste issue, I was wrong. However, if I think about it some more... What if you try to escape a dos shell character with \. Maybe it should look at both of them?? It is trying to distinguish between a path separator and a \ escaped character right? -Bill _______________________________________________ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
