martinvonz added inline comments.
INLINE COMMENTS
> gitlog.py:29
> +
> +class baselog(object): # revlog.revlog):
> + """Common implementations between changelog and manifestlog."""
Could we also get `__iter__`? We can of course add that later, but maybe it
seems easy to add anyway (`revlog.py` has `return
iter(pycompat.xrange(len(self)))`).
Maybe also copy the following from `revlog.py`?
def tiprev(self):
return len(self.index) - 1 # well, use "len(self)" here, I guess
def tip(self):
return self.node(self.tiprev())
def revs(self, start=0, stop=None):
"""iterate over all rev in this revlog (from start to stop)"""
return storageutil.iterrevs(len(self), start=start, stop=stop)
> gitlog.py:150
> + for x in self._db.execute(
> + 'SELECT node FROM changelog WHERE node LIKE ?', (id + b'%',)
> + )
Will the `?` be replaced by `abc123%` or `b'abc123%'` on py3? (Same applies
further down.)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6734/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6734
To: durin42, #hg-reviewers
Cc: martinvonz, sluongng, tom.prince, sheehan, rom1dep, JordiGH, hollisb,
mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
