martinvonz added a comment.
Just sending two comments I forgot to send yesterday. INLINE COMMENTS > durin42 wrote in __init__.py:126-129 > It honestly didn't occur to me to use the presence of `git` in `requires` to > trigger the "this is a git repo" behavior. Should I add a TODO about that? Please do, because that seems like the natural way for it to work. > durin42 wrote in gitlog.py:29 > I'm hoping we can only implement __iter__ on changelog, not on baselog. Ditto > for tip and revs, but I was going to block that on the interface definition > (I haven't yet seen anything that wants these methods...) > (I haven't yet seen anything that wants these methods...) I found some things while playing with the extension :) I don't remember anymore what those were. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734 To: durin42, #hg-reviewers Cc: mharbison72, martinvonz, sluongng, tom.prince, sheehan, rom1dep, JordiGH, hollisb, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
