martinvonz added inline comments.
INLINE COMMENTS
> durin42 wrote in gitlog.py:150
> It should be the former. I've actually been developing this extension
> exclusively on Python 3, so the tests already pass on 3.
I think I asked because I noticed that the `shortest()` template function
always returned the full hash and things were really slow (I assume that was
because of the byte string on line 173, not here). Does it work for you? (I'm
fine with adding a TODO about fixing it if you see the same brokenness.)
> gitutil.py:15-17
> + if pycompat.ispy3:
> + return hex(n).decode('ascii')
> + return hex(n)
equivalent to `return pycompat.sysstr(hex(n))` (would be using utf-8 instead of
ascii, but that shouldn't matter)?
> manifest.py:27
> +
> + Very similar to mercurial.manifest.treemanifest.
> + """
Call it `gittreemanifest` in that case?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6734/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6734
To: durin42, #hg-reviewers
Cc: mharbison72, martinvonz, sluongng, tom.prince, sheehan, rom1dep, JordiGH,
hollisb, mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
