durin42 added inline comments.

INLINE COMMENTS

> martinvonz wrote in gitlog.py:150
> I think I asked because I noticed that the `shortest()` template function 
> always returned the full hash and things were really slow (I assume that was 
> because of the byte string on line 173, not here). Does it work for you? (I'm 
> fine with adding a TODO about fixing it if you see the same brokenness.)

I'm seeing shortest() actually returning short hashes (4-bytes, like I've got 
configured) so I'm not sure what's broken.

I added a test, which passes under python3.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6734/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6734

To: durin42, #hg-reviewers
Cc: mharbison72, martinvonz, sluongng, tom.prince, sheehan, rom1dep, JordiGH, 
hollisb, mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to