LGTM, series is: Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
On 10/30/18 7:11 PM, Erik Faye-Lund wrote:
EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems reasonable to allow for the extension. This ended up mostly as code-cleanups anyway. While enabling this, one bug was discorvered due to a failing dEQP test (see the last patch). This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965. No piglit regressions observed. Erik Faye-Lund (5): glsl: add has_implicit_conversions()-helper glsl: add has_implicit_uint_to_int_conversion()-helper glsl: fall back to inexact function-match mesa/glsl: add support for EXT_shader_implicit_conversions glsl: do not allow implicit casts of unsized array initializers src/compiler/glsl/ast_function.cpp | 2 +- src/compiler/glsl/ast_to_hir.cpp | 8 ++++---- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 15 +++++++++++++++ src/compiler/glsl/ir_function.cpp | 3 ++- src/compiler/glsl_types.cpp | 5 ++--- src/mesa/main/extensions_table.h | 1 + 7 files changed, 26 insertions(+), 9 deletions(-)
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
