On 10/31/18 7:03 PM, Ilia Mirkin wrote:
On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund
<erik.faye-l...@collabora.com> wrote:
On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote:
I had to do a double (or triple) take on this logic as well. Part of
the subtlety is that the fallback only applies for ES when there's a
match but no exact match. Probably good to mention this.
Yeah, that makes sense. I thought I mentioneded this in the commit
message, but perhaps you want that to be more explicit than the "In
GLES, "-introduction?
How about I simply add something like "This fallback should only affect
GLES." at the end of the commit message?
Yes, you did mention it in the commit message. But that's unlikely to
be visible when reading this code. I was thinking something in this
function's comments would be nice.
Sounds good, I wouldn't be worried about saying it aloud, at least I
would love some 'spoon-feeding comments' now and then with compiler and
linker parts :)
// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
