> Small comment, you should plan on single build for all supported > generations.. I'm not entirely sure if this same header is eventually > planned to be #include'd from different C code w/ different defines > for gpu gen (afaict you just currently hard-code it at the top of this > header).. But distro's will be unhappy if it comes to different mesa > builds for 8xx vs 6xx ;-)
Yeah, that's a moderately high-prio item, only blocking on other things being more interesting ;) > Also, I guess for your sanity at some point you'll want to autogen > cmdstream encoding and decoding from a single source. I get the > impression that envytools isn't the right thing for the bitpacked > format for mali cmdstream. Maybe the intel thing is better? But I > didn't get very far w/ a2xx r/e before I realized that keeping hand > coded decoding and encoding in sync sucked. Sure, but.. autogen from.. what? As you note, Mali's "cmdstream" is wacky and doesn't line up with the model assumed by most of these tools. Also, if I have to read/write XML, I might lose my sanity faster ;P > Anyways, totally fine w/ those details getting worked out in-tree, > after merging. > > Acked-by: Rob Clark <robdcl...@gmail.com> Thank you! (Is there any particular ack we're waiting for for pushing?) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
