On Mon, Feb 4, 2019 at 3:13 PM Rob Herring <r...@kernel.org> wrote: > On Sun, Feb 3, 2019 at 9:33 PM Alyssa Rosenzweig <aly...@rosenzweig.io> > wrote: > > > > > You should just land it and start doing in-tree development! > > > > I don't have push access, you know :P > > I can push it if you don't want to go the MR route. That goes for > subsequent changes too. >
Actually, I just gave you (Alyssa) push access. You haven't hit the usual 2-dozen commit threshold in mesa main yet but that's because you've been working (very actively!) out-of-tree. I figure you'll hit that threshold very quickly once you start working in-tree. Also, as you'll (as far as I understand) basically be owning the panfrost bits in mesa, you should be able to commit to them. Please drink responsibly, don't run with scissors (unless they're the GL kind), and remember a few basic merging rules: 1. Don't break the build 2. No merge commits 3. Write good commit messages with reasonable prefixes (such as "panfrost: Implement clip planes for vertex shaders") 4. Don't commit code outside of Panfrost without review from someone who has a decent claim to knowing what they're talking about in that area 5. Be nice and give stake-holders (who may not be in your time zone) enough time to read their e-mail and review (at least 24 hours not including week-ends) before pushing anything. Inside Panfrost, it's kind-of up to the Panfrost community developers what you want to do about review. If you've got enough people, I highly recommend you do good code review. If it's really just you hacking on the compiler, then maybe review isn't practical. Happy hacking and welcome to the mesa tree! --Jason
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
