On Mon, Feb 4, 2019 at 6:25 PM Alyssa Rosenzweig <aly...@rosenzweig.io> wrote:
> > Actually, I just gave you (Alyssa) push access... Also, as you'll (as > > far as I understand) basically be owning the panfrost bits in mesa, > > you should be able to commit to them. > > Oh, thank you! :) > > > 1. Don't break the build > > Acked-by: Alyssa Rosenzweig <aly...@rosenzweig.io> > > > 2. No merge commits > > Just to be clear, is the idea to just make sure everything applies > cleanly / is a straightforward fast-forward, and if not, to rebase/squash > so it does? > Roughtly? I really did mean "no merge commits" which really just means linear history. Ideally, you'd have something that roughly linearly works but that's a Panfrost quality thing. I'm sure there will be regressions all over the place as you work given that it's still a bit prototypey. > > 4. Don't commit code outside of Panfrost without review from someone who > > has a decent claim to knowing what they're talking about in that area > > Acked-by: Alyssa Rosenzweig <aly...@rosenzweig.io> > > > 5. Be nice and give stake-holders (who may not be in your time zone) > > enough time to read their e-mail and review (at least 24 hours not > > including week-ends) before pushing anything. > > Acked-by: Alyssa Rosenzweig <aly...@rosenzweig.io> > > > Inside Panfrost, it's kind-of up to the Panfrost community developers > what > > you want to do about review. If you've got enough people, I highly > > recommend you do good code review. > > Downstream, we've been trying to enforce proper reivew. I review other > people's code; I haggle people to review mine; you know how it is :) > > Thank you again! > > Alyssa >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
