On Sun, 2010-01-03 at 08:45 -0800, Brian Paul wrote: > 2010/1/2 Chia-I Wu <olva...@gmail.com>: > > On Sat, Jan 02, 2010 at 07:01:02PM -0500, Kristian Høgsberg wrote: > >> We have all functions that need to be visible marked with PUBLIC and > >> this is trimming around 4% off the DRI driver .so size. > > I love this change! > > > > It might require another patch, but would it be possible to stop marking > > functions like _mesa_GenTextures as GLAPIENTRY? I think they are not > > public either in normal build. > > This would have to be checked on Windows. I think the x86 dispatch > code is sensitive to the Windows calling conventions implied by > GLAPIENTRY.
Brian is right. GLAPI controls symbol visibility, both on unices (i.e., _attribute__((visibility("default")))) and windows (i.e., _declspec(dllexport). GLAPIENTRY controls the calling convention (i.e., __stdcall presence or absence). This can be easily seen on top of GL/GL.h. So in summary, GLAPI can and probably should be removed for _mesa_* functions. GLAPIENTRY cannot. Jose ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev