On Sat, Feb 6, 2010 at 9:38 PM, Marek Olšák <mar...@gmail.com> wrote: > The attached patch series relaxes precision requirements for 6 tests to pass > on r300g. > > Please review/push.
The glean-related patches should get applied upstream in glean first. I can take care of those. Re: tclipflat.cpp: it's a little disturbing that pure green (0,255,0,0) can't be propagated through the pipeline when doing flat shading, no lighting, etc. There may be a deeper problem here. Re: fbo-cubemap.c: I'd like to see a better name than -r300relax for the command line flag (and the hack_r300relax variable). The idea is you're skipping the test for mipmap levels smaller than 2x2 texels, right? How about "-skipsmalllevels" or something like that? There should probably be a comment in the code to explain what you're doing too. Re: copytexsubimage.c: it would be nice if piglit had more infrastructure for comparing an actual color to an expected color. Something like: GLboolean piglit_color_matches(const float actual[4], const float expected[4], const float tolerance[4]); Where tolerance might be a hard-coded thing, or computed from the color buffer bits/channel, etc. For the time being in copytexsubimage.c, how about putting the comparison code into a function? That'd be a bit nicer. -Brian ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
