Eric,
yes, it does.
I decided to resolve my precision issues using glDisable(GL_DITHER). The two
patches disable dithering, the former in piglit and the latter in glean. I
see no point in separating them to smaller ones but I can do that if you
like. Since it's tricky to test dithering anyway, disabling it is
preferable. Could you please push the first one if there are no objections?
Brian,
Could you please push the second one into glean if there are no objections?
-Marek
On Thu, Feb 11, 2010 at 1:42 AM, Eric Anholt <e...@anholt.net> wrote:
> On Sun, 7 Feb 2010 05:38:01 +0100, Marek Olšák <mar...@gmail.com> wrote:
> > The attached patch series relaxes precision requirements for 6 tests to
> pass
> > on r300g.
> >
> > Please review/push.
>
> I just pushed a change to do the r300relax type path always on cubemap
> and fbo-cubemap. It sounds like the decision was that the dithering at
> 32bpp was doing strange things and the solution was to just disable it
> in that case -- right? If so, does that leave any patches still to be
> committed for the piglit side of things?
>
>
From dc274f1caf050f23f8489f316c52621df679e87b Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Marek=20Ol=C5=A1=C3=A1k?= <mar...@gmail.com>
Date: Wed, 10 Feb 2010 02:00:17 +0100
Subject: [PATCH 1/4] copytexsubimage,fbo-pbo-readpixels-small,tex3d: disable dithering
---
tests/fbo/fbo-pbo-readpixels-small.c | 2 ++
tests/texturing/copytexsubimage.c | 2 ++
tests/texturing/tex3d.c | 2 ++
3 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tests/fbo/fbo-pbo-readpixels-small.c b/tests/fbo/fbo-pbo-readpixels-small.c
index 09740d2..1f50700 100644
--- a/tests/fbo/fbo-pbo-readpixels-small.c
+++ b/tests/fbo/fbo-pbo-readpixels-small.c
@@ -161,4 +161,6 @@ void piglit_init(int argc, char **argv)
{
piglit_require_extension("GL_EXT_framebuffer_object");
piglit_require_extension("GL_ARB_pixel_buffer_object");
+
+ glDisable(GL_DITHER);
}
diff --git a/tests/texturing/copytexsubimage.c b/tests/texturing/copytexsubimage.c
index 481c731..2e79174 100644
--- a/tests/texturing/copytexsubimage.c
+++ b/tests/texturing/copytexsubimage.c
@@ -264,6 +264,8 @@ static void display(void)
static void init(void)
{
+ glDisable(GL_DITHER);
+
glMatrixMode( GL_PROJECTION );
glPushMatrix();
glLoadIdentity();
diff --git a/tests/texturing/tex3d.c b/tests/texturing/tex3d.c
index c3854f9..1647d82 100644
--- a/tests/texturing/tex3d.c
+++ b/tests/texturing/tex3d.c
@@ -226,6 +226,8 @@ piglit_init(int argc, char **argv)
glutReshapeFunc(Reshape);
+ glDisable(GL_DITHER);
+
glGenTextures(1, &Texture);
glBindTexture(GL_TEXTURE_3D, Texture);
Reshape(piglit_width, piglit_height);
--
1.6.3.3
From 7e9a5849689b78f0ac0275e9fde6b4b78f1aab1d Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Marek=20Ol=C5=A1=C3=A1k?= <mar...@gmail.com>
Date: Thu, 11 Feb 2010 00:16:56 +0100
Subject: [PATCH 4/4] glean/clipFlat,fbo,texture_srgb: disable dithering
---
tests/glean/tclipflat.cpp | 1 +
tests/glean/tfbo.cpp | 2 ++
tests/glean/ttexture_srgb.cpp | 2 ++
3 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tests/glean/tclipflat.cpp b/tests/glean/tclipflat.cpp
index a2798c0..db5726d 100644
--- a/tests/glean/tclipflat.cpp
+++ b/tests/glean/tclipflat.cpp
@@ -200,6 +200,7 @@ ClipFlatTest::setup(void)
glFrontFace(GL_CW);
glCullFace(GL_FRONT);
glEnable(GL_CULL_FACE);
+ glDisable(GL_DITHER);
provoking_vertex_first = GLUtils::haveExtension("GL_EXT_provoking_vertex");
diff --git a/tests/glean/tfbo.cpp b/tests/glean/tfbo.cpp
index d76fc2d..fda1da0 100644
--- a/tests/glean/tfbo.cpp
+++ b/tests/glean/tfbo.cpp
@@ -85,6 +85,8 @@ FBOTest::setup(void)
glDrawBuffer(GL_FRONT);
glReadBuffer(GL_FRONT);
+ glDisable(GL_DITHER);
+
// compute error tolerances (may need fine-tuning)
int bufferBits[5];
diff --git a/tests/glean/ttexture_srgb.cpp b/tests/glean/ttexture_srgb.cpp
index e27081b..7a85a3d 100644
--- a/tests/glean/ttexture_srgb.cpp
+++ b/tests/glean/ttexture_srgb.cpp
@@ -172,6 +172,8 @@ TextureSRGBTest::testTextureFormat(GLenum intFormat, GLint components,
glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE);
glEnable(GL_TEXTURE_2D);
+ glDisable(GL_DITHER);
+
glDrawBuffer(GL_FRONT);
glReadBuffer(GL_FRONT);
--
1.6.3.3
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
