On 06/08/2015 09:51 AM, Sébastien BLAISOT wrote: > > > Hi, > > I did recently, as asked by RJ, added some coding style commit in a PR, > particularly on the following rule: > > _Plain-text comments should be separated from the comment symbol by a > single space. Commented-out code should have no space between the > comment symbol and the code_ > > I'm not sure that this kind of rule can be automatically enforced > (detecting if comment is code or plain text is not easy).
Yeah this is not possible. The best solution would be to delete the dead-code. We actually have some useful dead debug statements somewhere but most code gets deleted eventually anyway. And personally I'm not so set on the spacing rule for code vs text comments. Every commenting engine I used so far can't handle this case. > > +1 for automatic code review that can enforce coding style, security and > sanity checks, ... > ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
