PR 649 is ready. I'll finish up PR 638 tonight. On 07/22/2015 04:02 PM, Owen Williams wrote: > For PRs that people think are ready and would like to merge in, can you > list the actual numbers? Our PR list is very dense and fast-moving. > > I am willing to take a look at the PRs that are in flight, but I can't > guarantee that I will agree that everything is low risk or ready to > merge. If people trust me enough to make that decision then the process > can work, but if not then I'd rather not spend the time doing the > review. If someone asks for my review and they don't like the answer, > then they didn't want a review, they wanted a rubber stamp :). I am > admittedly quite conservative when it comes to LGTMing a PR for the > beta, but I'd argue that's what we need. > > It would also be nice if our milestone list was more realistic: > https://launchpad.net/mixxx/+milestone/1.12.0 There are tons of bugs > targeted to 1.12 that will not get fixed and shouldn't block the > release. I'd like people to go through the list and remove the target > milestone if they don't think a bug should really block the release. > (Don't switch the milestone to the next version either, just remove it.) > This even goes for crashers that are just too hard to reproduce. > > For instance, as much as it annoys me that the analyze pane doesn't pick > up the custom font choice, it's not worth blocking over. > (https://bugs.launchpad.net/mixxx/+bug/1427368) > > Owen > > On Wed, 2015-07-22 at 10:50 -0500, Be wrote: >> Most of the issues listed by Sebastian and I are low risk and pretty >> much ready to merge. The points that aren't being addressed yet are the >> flaky broadcasting connection, Opus crash, and library search bar focus >> issue. I'd be fine merging the key sorting as is without polishing it >> for the Lancelot notation system if that's not ready by release time. >> >> On 07/22/2015 09:12 AM, RJ Ryan wrote: >>> Daniel/RAWRR are right -- the goal posts are moving slightly and we're >>> scope creeping. >>> >>> Active, trivial / low-risk PRs can merge if they are ready but shouldn't >>> be blocking. >>> >>> For me, the final blocker is the manual and website / press material -- >>> which we simply can't launch without. :) >>> >>> Best regards, >>> RJ >>> >>> On Wed, Jul 22, 2015 at 8:11 AM, Ferran Pujol Camins >>> <ferranpujolcam...@gmail.com <mailto:ferranpujolcam...@gmail.com>> wrote: >>> >>> From my point of view, marketing wise, we could consider 1.12 a >>> modest release. Because despite the huge amount of work there's >>> behind it, every review out there will essentially say "it is great >>> and finally have FX, but the built in FX are weak". >>> >>> So my modest opinion is the same that Daniel. >>> >>> El dia 22/07/2015 12:16, <re-cy...@hushmail.com >>> <mailto:re-cy...@hushmail.com>> va escriure: >>> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> >>> >>> On Wed, 22 Jul 2015 06:28:38 +0000 "Daniel Schürmann" >>> <dasch...@mixxx.org <mailto:dasch...@mixxx.org>> wrote: >>> >Hi, >>> > >>> >We have to be careful to consider what is a release blocker. >>> >Mixxx 1.12 beta is already so much better than 1.11 that it is >>> not >>> >worth to >>> >block it at all from this point of view. >>> > >>> >Of cause we should try to fix all critical bugs before a release >>> >date, but >>> >in this stage I consider a >>> >release blocker only a regression that prevents one from using >>> >1.12. >>> >>From this point of view only this one is a blocker: >>> >* flaky broadcasting connections: LP 1277274 >>> > >>> >The other topics are its the over all quality issue. >>> > >>> >Everyone can already use 1.12 beta. What is the difference to a >>> >1.12 >>> >release? >>> >IMHO it is all the shiny stuff that makes the difference from a >>> >project to >>> >a product. >>> >It is marketing, design, manual, advertising texts, screen shots >>> >and so on. >>> >A product with good maketing/design is always considered as high >>> >quality, >>> >regardless >>> >of the number of critical bugs. >>> > >>> >Unfortunately marketing experts are rare among our contributors. >>> >Any Idea to change this? >>> > >>> >>> Yeah. >>> >>> If the betas really are that close, arrive at a consensus regarding >>> some reasonable candidate among these beta versions to designate as >>> a release, publish it, and continue on behind the scenes >>> developing, like you do. >>> >>> Mixxx is marketed really well already. If you are thinking >>> representation to the public is unclear, consider that perception >>> will be clarified when the download page has a "release", and >>> further accentuated with the usual rounds of well-crafted press >>> submissions to various DJ industry and tech sites and magazines >>> (which one of you folks usually does that anyway?). >>> >>> It seems like everyone in development wants 1.12 to be a singular, >>> glorious debut - but I think looking for that misses the mark. >>> There is an actual glorious debut, but it was and is the momentum >>> in productivity that fired up six months or so ago and will push >>> all the way through 1.12 to the continuing evolution of the >>> project, and a more modern style of development cycle. >>> >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Also my personal two cents about the roadmap (apologies if it is >>> off-base): I think new feature sprawl might be happening? If so, I >>> myself probably contributed to it. I know this observation won't be >>> popular!! Everyone wants and loves new features. But I think many >>> of the debates going on will be less exasperating and more >>> manageable when there are fewer projects underway in general. >>> Between 1.11 and 1.12, so much got piled on the plate!! Even as >>> someone without responsibilities free to simply observe, I find it >>> difficult to keep track of all the threads underway. >>> >>> ~RAWRR >>> >>> >Kind regards, >>> > >>> >Daniel >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> >2015-07-22 7:55 GMT+02:00 Be <b...@gmx.com >>> <mailto:b...@gmx.com>>: >>> > >>> >> >>> >> >>> >> On 07/22/2015 12:00 AM, Sébastien BLAISOT wrote: >>> >> > Hi all, >>> >> > >>> >> > Some more blockers : >>> >> > >>> >> > * (win) installing 1.12 on top of a previous version >>> >installation >>> >> > (lp:1457618) => PR621 is *still* waiting for merge. Please >>> >review and >>> >> > discuss if we move version to beta2 >>> >> > >>> >> > * (win) Eject symbol not shown in LateNight skin (lp:1454649) >>> >=> PR627 >>> >> > is *still* waiting for review and merge >>> >> >>> >> Who can review these? Who uses Windows? >>> >> >>> >> > About startup time, I noticed, under windows, that startup >>> >time is >>> >> > *very* long if I have network shares mounted and a slow (like >>> >> > slooooooow) network connection. Mixxx probably tries to >>> >enumerate all >>> >> > drives at startup, even network ones. I think it should be >>> >limited to >>> >> > local drives. Launch time is short if I unmount network >>> shares >>> >before >>> >> > launching mixxx. Hope this can be of any help in sorting out >>> >this issue. >>> >> >>> >> Why does Mixxx need to enumerate all drives at startup? >>> >Shouldn't it >>> >> only need to enumerate drives that the library is configured to >>> >scan in? >>> >> >>> >> > --- >>> >> > Sébastien Blaisot >>> >> > >>> >> > Le 22/07/2015 00:03, Be a écrit : >>> >> > >>> >> >> Where are we now? Let's make a list of release blockers: >>> >> >> * skin polish: Ferran's updates to LateNight in PR #639 is a >>> >good step >>> >> >> and he said he'd work on Deere too >>> >> >> * weird bug with library search bar focus in LateNight: >>> >> >> https://bugs.launchpad.net/mixxx/+bug/1462061 >>> >> >> * Startup time: Mixxx takes a long time to start up on some >>> >systems. PR >>> >> >> #655 and PR #650 will alleviate the issue without risking >>> >regressions by >>> >> >> messing with the startup code much. >>> >> >> * Opus crash: LP 1458380 >>> >> >> * flaky broadcasting connections: LP 1277274 >>> >> >> * key sorting: PR #649 in progress >>> >> >> * updating documentation links: PR #657 >>> >> >> * manual updates. IMO the people who wrote new features >>> >should be the >>> >> >> ones who explain how they work. >>> >> >> >>> >> >> * Electrix Tweaker mapping: PR #638 is almost ready. I ran >>> >into a bug >>> >> >> where I couldn't exit a loop using my controller last night. >>> >I'm not >>> >> >> sure if it was an issue with the mapping or Mixxx. >>> >> >> * Pioneer DDJ-SB mapping: How is progress on this Joan? Can >>> >you put it >>> >> >> on GitHub? See >>> >> >> http://mixxx.org/wiki/doku.php/midi_scripting#setting_up_git >>> >>> >for >>> >> setting >>> >> >> up git for mappings. >>> >> >> >>> >> >> On 06/14/2015 12:33 PM, Sébastien Blaisot wrote: >>> >> >>> >>> >> >>> OK, trying to gather what we said about "1.12 release >>> >blockers": >>> >> >>> >>> >> >>> Done: >>> >> >>> * skin polish (Jus has an active Deere branch) => PR579 & >>> >PR608 merged. >>> >> >>> * (win) installing 1.12 on top of a previous version >>> >installation => >>> >> >>> PR621 waiting for merge >>> >> >>> * (win) Uninstalling Mixxx leave files behind => PR603 >>> >merged >>> >> >>> * (win) Incorrect preferences folder path => PR606 merged >>> >> >>> >>> >> >>> Remaining: >>> >> >>> * critical Windows bugs => RJ told he will have a look at >>> >them. can we >>> >> >>> list the critical blockers here ? >>> >> >>> * skin polish (Jus has an active Deere branch) => bug >>> >lp:1454649 >>> >> >>> remaining. Is there other work needed ? >>> >> >>> * website updates (RJ ryan is working on this). We also >>> need >>> >to open >>> >> >>> more languages for website translation on transifex. it's >>> >actually >>> >> >>> limited to english, german, portuguese and Turkish. I can >>> >make french >>> >> >>> (france) translation. >>> >> >>> * manual updates => Does somebody work on this actually ? >>> >> >>> * avoid flanger warning message for shipped with mixxx >>> >controller >>> >> >>> mappings (hack it by making an ignore list) => Does >>> somebody >>> >work on >>> >> >>> this actually ? >>> >> >>> * XDG folders under Linux : We have to decide if it is a >>> >1.12 issue or >>> >> >>> if we postpone it. see lp:1463273 and PR622 >>> >> >>> * Unstable broadcasting stream => lp:1277274 >>> >> >>> >>> >> >>> >>> >> >>> Is there any other blockers ? >>> >> >> >>> >> >> >>> >> >> >>> >> >> >>> >> >>> ----------------------------------------------------------------- >>> >------------- >>> >> >> Don't Limit Your Business. Reach for the Cloud. >>> >> >> GigeNET's Cloud Solutions provide you with the tools and >>> >support that >>> >> >> you need to offload your IT needs and focus on growing your >>> >business. >>> >> >> Configured For All Businesses. Start Your Cloud Today. >>> >> >> https://www.gigenetcloud.com/ >>> >> >> _______________________________________________ >>> >> >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> >> >> http://mixxx.org >>> >> >> >>> >> >> >>> >> >> Mixxx-devel mailing list >>> >> >>Mixxx-devel@lists.sourceforge.net >>> <mailto:Mixxx-devel@lists.sourceforge.net> >>> >> >> <mailto:Mixxx-devel@lists.sourceforge.net >>> <mailto:Mixxx-devel@lists.sourceforge.net>> >>> >> >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >> >>> >> >>> >> >>> ----------------------------------------------------------------- >>> >------------- >>> >> Don't Limit Your Business. Reach for the Cloud. >>> >> GigeNET's Cloud Solutions provide you with the tools and support >>> >that >>> >> you need to offload your IT needs and focus on growing your >>> >business. >>> >> Configured For All Businesses. Start Your Cloud Today. >>> >> https://www.gigenetcloud.com/ >>> >> _______________________________________________ >>> >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> >> http://mixxx.org >>> >> >>> >> >>> >> Mixxx-devel mailing list >>> >> Mixxx-devel@lists.sourceforge.net >>> <mailto:Mixxx-devel@lists.sourceforge.net> >>> >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >> >>> -----BEGIN PGP SIGNATURE----- >>> Charset: UTF8 >>> Version: Hush 3.0 >>> Note: This signature can be verified at >>> https://www.hushtools.com/verify >>> >>> >>> wpwEAQMCAAYFAlWvbR4ACgkQzo/Gj4mkNMxoegP8Dhsih+vn/wmW7kstN2iox4U9P0Uj >>> >>> xFxBkIF9XNcxTW8LvPE/iIpKNc/Ssm1Zg3YmNK9wcIumxHRf6Ul7FRgsag2dHGV7s8WE >>> >>> CRVs84GOtUuH6QbrAO+q7KY9W61KWIt0k551GyRTuHSkvTwdGFn4KqUJYX1XeLEFcdIz >>> pSsJkwY= >>> =KJb6 >>> -----END PGP SIGNATURE----- >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Don't Limit Your Business. Reach for the Cloud. >>> GigeNET's Cloud Solutions provide you with the tools and support >>> that >>> you need to offload your IT needs and focus on growing your >>> business. >>> Configured For All Businesses. Start Your Cloud Today. >>> https://www.gigenetcloud.com/ >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> <mailto:Mixxx-devel@lists.sourceforge.net> >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Don't Limit Your Business. Reach for the Cloud. >>> GigeNET's Cloud Solutions provide you with the tools and support that >>> you need to offload your IT needs and focus on growing your business. >>> Configured For All Businesses. Start Your Cloud Today. >>> https://www.gigenetcloud.com/ >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> <mailto:Mixxx-devel@lists.sourceforge.net> >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> >>> >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> >> > >
------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
