I must say I'm impressed, you've even taken care of a wish I made time ago to hide the BPM info :)
Ok, here are my thoughts. There's a lot of things, keep in mind I say all this with a constructive attitude and that this is just my personal opinion :) -I love the spinnies, they are neat and cool. However, they are a bit deformed near the gap, you can see this when they spin. -The buttons next to the overview waveform don't follow the same layout than the latest Deere and Shade (PR #639 <https://github.com/mixxxdj/mixxx/pull/639>). In particular, the crossfader assign button is missing. We could add the slip mode button to LateNight and Shade as well to keep consistency between skins. We could ditch the key lock switch to make room for the slip mode button, it would be better placed next to the key knob like it already is in Deere. -When on 4 decks mode, if I switch to stacked waveforms, the window becomes too big for my screen which is annoying. This option should be disabled if the user's screen is too small. If this is not possible with the current codebase maybe we can omit this feature for 1.12, we already have LateNight for people wanting stacked waveforms. -The buttons of the mixer are tiny, difficult to see if the DJ is at a distance from the screen and they can't be easily clicked. -I would ditch the skin settings pane. It's clever, but is not standard among skins. From my point of view, we should avoid custom skin CO and confine ourselves to the standard CO until we have a way to fully integrate these skin specific CO to Mixxx (make them appear to the view menu for example). -The view section is already managed by the view menu in (PR #639 <https://github.com/mixxxdj/mixxx/pull/639>). -The option to show cover art either on the spinnies or the title is cool. We could add this to all skins and add a new default CO. Otherwise I wouldn't include it to 1.12. The same for hide/show bpm and track info. -For the samplers and FX advanced mode we already have the corresponding show/hide CO. They also have a button on the skin. -Maximize library needs a button right on the skin. The upper bar is a good place. -I don't see a point on being able to hide the library when no other widgets take advantage of the space it leaves. I would disable this option in these situations, like the latest LateNight does (PR #639 <https://github.com/mixxxdj/mixxx/pull/639>). -The slip mode spinny keeps running when the cue button is pressed. But this might be a bug in Mixxx. -The look of the faders is not consistent with the look of the knobs. -The skin minimum width needs to be increased a bit. -We could show more cue points automatically with a SizeAwareStack. -The loop and beat jump numbers could be decreased with a right click. Also, can be deck-independent? -Just opinion: what if we make the colors darker? 2015-07-24 16:23 GMT+02:00 Owen Williams <owilli...@mixxx.org>: > How about we create a sub-branch of 1.12 and merge your work there, and > then we can have others help out. When it's in good shape we can merge > it back into 1.12. (That way 1.12 stays pristine while we are cleaning > things up.) > > On Fri, 2015-07-24 at 16:11 +0200, S.Brandt wrote: > > Hi, > > Deere maintainer here. > > My current dev branch: [1] > > Fixes (mostly) all bugs for the skin listed: [2] > > It merges cleanly [3], but i`ve submitted no PR yet since it is still > > unfinished, some items on my todo. > > > > > > Unfortunately, time is an major issue. > > > > > > Suggestion? > > Test the skin in its current state and comment and/or submit PR. > > > > > > [1]: https://github.com/esbrandt/mixxx/tree/deere_updates > > [2]: https://blueprints.launchpad.net/mixxx/+spec/1.12-skins > > [3]: > > > https://github.com/mixxxdj/mixxx/compare/1.12...esbrandt:deere_updates?expand=1 > > ------------ > > S.Brandt > > Mixxx - Free Digital DJ Mixing Software > > www.mixxx.org | Get Involved > > > > > On Jul 23, 2015, at 8:28 PM, Ferran Pujol Camins > > > <ferranpujolcam...@gmail.com> wrote: > > > > > > Hello, I thought I could put some love to Deere. But before I start > > > to commit things that may not be appropriate, I would like to know > > > if there are any specific plans for it. Whose the maintainer? Any > > > suggestions? > > > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > Mixxx-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > >
------------------------------------------------------------------------------
_______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
