Excellent list - I just integrated virtually all of your points:
http://github.com/jeresig/sizzle/commit/93e33dc2a41e2b0aa0e1e1c66368f5d224da80e1
The exception is :visible and :hidden - which should be handled by the
host library.
Also, I wrapped the entireity of Sizzle withing a (function(){ ...
})() which means that no global variables are exposed (save for
Sizzle).
What specific code do you use to hook Sizzle in to your engine? What
I'll probably do is just hook it directly in to the right spot (for
example, overwrite jQuery.find, in the case of jQuery) rather than
introduce a new global variable.
--John
On Mon, Oct 20, 2008 at 10:51 AM, Arnar Birgisson <[EMAIL PROTECTED]> wrote:
> Hi again,
>
> On Mon, Oct 20, 2008 at 16:43, John Resig <[EMAIL PROTECTED]> wrote:
>> Just to clarify: Are you turning on JIT in 3.1?
>
> JIT is off.
>
>> Do you have a diff of any change(s) that you've made to your copy of Sizzle?
>
> Yup. http://www.hvergi.net/arnar/public/sizzle/diff.txt
>
> cheers,
> Arnar
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to mochikit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---
