I don't follow the Sizzle development very closely, but I seem to remember having seem some check-ins dealing with similar issues.
Perhaps the time is right now to just go ahead and merge the new selector branch into the 1.5 trunk? With the appropriate updates from the base Sizzle implementation of course. Also, please note that the MochiKit Customizer assumes that each module starts with a call to _deps and ends with a call to _export, so please make sure that the new Selector module also follows that pattern. Cheers, /Per On Tue, Nov 4, 2008 at 11:36 AM, Arnar Birgisson <[EMAIL PROTECTED]> wrote: > > Hello Giulio Cesare, > > First: wow - your name is awesome :) > > On Mon, Nov 3, 2008 at 11:56, Giulio Cesare Solaroli > <[EMAIL PROTECTED]> wrote: >> I would like to ask if the new implementation is "currentWindow" aware >> or (like it seems form a quick look at the code) is still accessing >> directly the document object. >> >> I will try to make a few test case to see if I am doing something >> wrong with my current code or there is really a problem here. > > I want the new implementation to be currentWindow aware (or rather > currentDocument) - and I tried to put the call in the right places. > However, I'm not entirely sure that Sizzle handles this correctly. > I.e. Sizzle might implicitly make the assumption that one is using > window.document in some places. I pointed this out to John and he > could not confirm either way, I think he means to have a look at it. > > In the meantime, test-cases for this would be greatly appreciated. If > you find specific problems, please make a track issue and/or submit a > patch if you can. > > cheers, > Arnar > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MochiKit" group. To post to this group, send email to mochikit@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mochikit?hl=en -~----------~----~----~----~------~----~------~--~---
