On Nov 22, Joe Schaefer wrote:
> But before anyone bites off more than they can chew, perhaps some 
> discussion of the current bugs and future needs for libapreq should 
> be aired out.

the issues i know of:

* memory bloat from multipart buffer code (but there's your patch
and the one i've sent the list that both address this)

* workaround to handle multipart/form-data data sent from internet
explorer on the macintosh from forms with image submits which are
sent with an incorrectly terminated boundary string, if i remember
the details correctly. the patch i've sent to the list addresses
this, too.

* in ApacheRequest_parse_urlencoded, 'data' isn't initialized
properly, which can result in processes spinning out of control.
(fixed in the patch i've sent before, but a trivial fix anyway.)

* the content-type tests don't handle encodings quite right
(patch: http://www.mail-archive.com/modperl@apache.org/msg08188.html)

* i seem to remember there being a bug in the cookie handling that
choked when an undefined value was passed in. easy to fix once the
details are dug up. (this may actually have been something in
mod_perl itself that i'm misremembering.)

* win32 patches?

things that could be added to libapreq:

* intelligent cross-request-phase handling of posted form data, a
la RequestNotes. (it looks to me like the data is already allocated
out of the per-request pool, so it should just be a matter of
stuffing the data in the real request rec instead of the Apache::Request
object so the next Apache::Request object can see the data.)

* $apr->parms documented (possibly with a better name, as doug
has suggested)

* someone has suggested that Apache::Cookie->new should check
the first argument to make sure it is passed the right thing.
(http://www.mail-archive.com/modperl@apache.org/msg05151.html)

* the whole thing just folded into mod_perl since it is, in my
opinion, indispensable. :)

there's also the few things in the ToDo file in the libapreq
distribution.

jim

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to