Mark Stosberg wrote: > I think I want to make some slight tweaks to the API, but it's about > ready for 1.0. It's built around my own common usage: Uploading images > and storing meta data in a database. However, it works fine for non > images as well.
I think this module should be called CGI::Image::Upload, or perhaps even CGI::Application::Image::Upload. It's not a generic module for uploading images (it makes assumptions about the fact that you're using DBI for example). And there's certainly far too much image specific functionality to warrant such a general name. The facility to create image thumbnails, for example, certainly doesn't belong in a generic CGI::Upload module. It's really just a module that implements your particular image upload web application, IMHO. There's nothing wrong with that, and there's plenty of room on CPAN for it, if you want to upload it. But please give it a name that reflects what it actually does. > BTW, I looked at CGI::Upload too and don't currently recommend it. Check out > the bug reports currently filed against it. CGI::Upload looks like it fits the bill perfectly to me. It does one thing and from what I can tell, it does it well. I can see two minor bugs that require little more than a line or two of changes to fix them, and one feature request which includes code. Are there some other bugs I'm missing? Personally I would rather see efforts made on fixing these bugs than releasing a new module with an almost identical name that does something less useful for most of the people, most of the time. A
