Okay, I'll take a look at that when SVN is up again. Also, don't call them "Jason's Patches". That makes it sound like I was clever... I wasn't. It's Moller's code, and his algorithm is very very clever.
--jason Jason Worth Martin Asst. Professor of Mathematics http://www.math.jmu.edu/~martin On Sat, Nov 1, 2008 at 9:55 AM, Bill Hart <[EMAIL PROTECTED]> wrote: > > Jason, first bug report. When I build mpir with your patches (I have > got the mpir repo working locally for me only - hopefully Michael will > help me with the apache export so everyone else can get access again), > I get warning messages in the compile on sage.math. > > gcd.c: In function 'mpz_rgcd': > gcd.c:167: warning: implicit declaration of function 'mpn_rgcd' > gcd.c: In function 'mpz_bgcd': > gcd.c:171: warning: implicit declaration of function 'mpn_bgcd' > gcd.c: In function 'mpz_sgcd': > gcd.c:175: warning: implicit declaration of function 'mpn_sgcd' > gcd.c: In function 'mpz_ngcd': > gcd.c:179: warning: implicit declaration of function 'mpn_ngcd' > > It seems to build ok otherwise. > > Bill. > > 2008/11/1 Jason Martin <[EMAIL PROTECTED]>: >> >> On Fri, Oct 31, 2008 at 9:11 PM, mabshoff >> <[EMAIL PROTECTED]> wrote: >>> [snip] >>> For me the highest priority item is the Moller's gcd code which has >>> already been merged. What is the status of the code, i.e. performance, >>> any known bugs, etc? >>> >>> Cheers, >>> >>> Michael >> >> Hi Michael, >> >> I haven't tested Moller's code beyond the standard make check test >> suite (which passes all tests). I also haven't done any speed tests >> other than the most rudimentary checks. So if anyone has some >> suggestions for test cases, I'd be happy to try them out. Likewise, >> if anyone has any bug reports for the gcd code, let me know and I'll >> attempt to figure it out. >> >> >> --jason >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "mpir-devel" group. To post to this group, send email to mpir-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/mpir-devel?hl=en -~----------~----~----~----~------~----~------~--~---
