Brian Gladman wrote:
On 24/06/2013 16:10, leif wrote:
leif wrote:
Brian Gladman wrote:
On 24/06/2013 15:10, Bill Hart wrote:
Hi,

I recall we had a warning related to ___gmpn_preinv_mod_1 which got
fixed before the mpir-2.6.0 release. But despite this sounding like a
familiar problem, I haven't been able to find a post where it was dealt
with in the past.

Can you post a copy of your config.h to help us get to the bottom of
it.

Perhaps Brian has some idea what is going on here. However, I am not
sure if we are supporting vs2008 any more.

We do through the command line build that Jason provided but this is now
unsupported.

I have sometimes seen this problem when a build uses old configuration
files so it might be worth checking that a full clean has been done
before the build is started.

Shooting into the dark:  Isn't probably just the MPN_PATH wrong
(opposite order, such that it doesn't match the definitions in config.h,
especially HAVE_NATIVE_mpn_preinv_mod_1, which is 1):

  > (set MPNPATH=x86w x86w\p6 x86w\p6\mmx x86w\p6\p3mmx)

P.S.:  ___gmpn_preinv_mod_1 is implemented in x86w/p6, but now x86w.


And/or:  Maybe just a typo in MPNPATH (should be MPN_PATH on Windows as
well I guess).

It is MPNPATH in Jason's command line build files.

Ah, I see. And I actually thought the (set ...) commands were typed manually, but they're actually generated by configure.bat... -- sorry for the noise. :-)


The order of the folders in MPNPATH is correct, and we even have


:: dont know what the asm version have so delete them
del preinv_divrem_1.obj preinv_mod_1.obj divrem_1.obj mod_1.obj divrem_euclidean_qr_1.obj > nul 2>&1
cl %OPT% -I..\.. ..\..\mpn\generic\divrem_1.c
if errorlevel 1 goto :err
cl %OPT% -I..\.. ..\..\mpn\generic\mod_1.c
if errorlevel 1 goto :err
cl %OPT% -I..\.. ..\..\mpn\generic\divrem_euclidean_qr_1.c
if errorlevel 1 goto :err
cl /D "USE_PREINV_DIVREM_1" %OPT% -I..\.. ..\..\mpn\generic\preinv_divrem_1.c
if errorlevel 1 goto :err
cl %OPT% -I..\.. ..\..\mpn\generic\preinv_mod_1.c
if errorlevel 1 goto :err


in make.bat, but also


#if !HAVE_NATIVE_mpn_preinv_mod_1

/* This function used to be documented, but is now considered obsolete.  It
   continues to exist for binary compatibility, even when not required
   internally.  */

mp_limb_t
mpn_preinv_mod_1 (mp_srcptr up, mp_size_t un, mp_limb_t d, mp_limb_t dinv)
...


in mpn/generic/preinv_mod_1.c, such that this indeed doesn't work with the setting in config.h (where HAVE_NATIVE_mpn_preinv_mod_1 was set to 1).

So just turning that 1 into 0 in config.h and rerunning make.bat /should/^TM work...


And upstream should probably change the line in win/make.bat to

cl /D "USE_PREINV_MOD_1" %OPT% -I..\.. ..\..\mpn\generic\preinv_mod_1.c

and mpn/generic/preinv_mod_1.c accordingly:

#if !HAVE_NATIVE_mpn_preinv_mod_1 || defined(USE_PREINV_MOD_1)



-leif

--
() The ASCII Ribbon Campaign
/\   Help Cure HTML E-Mail

--
You received this message because you are subscribed to the Google Groups 
"mpir-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mpir-devel+unsubscr...@googlegroups.com.
To post to this group, send email to mpir-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/mpir-devel.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to