On 2013/01/15 21:13, Denis Krjuchkov <de...@crazydev.net> wrote:
> 16.01.2013 2:05, Max Kellermann ??????????:
> >Is the problem that the "native 8 bit charset" is not capable of
> >representing all possible wchar_t file names?  If that's the case,
> >then I guess we should be using TCHAR.
> 
> Yes, the problem is that some characters could not be represented this way.
> 
> UTF-8 approach is less pervasive and UTF-16 <-> UTF-8 conversions
> shouldn't hurt performance too much.

Hm, ok, I think wrapping everything in our own functions is not
exactly the most beautiful solution, but will do.  (It creates a third
character set: UTF-8 for data/protocol strings, internal FS charset,
external FS charset)

Though I believe your change in server_socket.c is wrong.  The
"narrow" path is used in s_un.sun_path, but you delete the "wide" path
name in the u_unlink() call.  Anyway, that part of the MPD code isn't
portable to Windows.

What's your plan for path names that are passed to other libraries?
Will MPD work for some codecs, but not for others?  Known
bug/limitation?

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to