16.01.2013 18:25, Max Kellermann пишет: > It doubles the overhead. Could you provide an example? I can't really imagine how this doubles overhead.
> And no, there isn't even any additional correctness verification to > justify it. You can still pass MPD's internal path names to standard > I/O functions. This is a drawback I agree. > What I suggest: use that path class for *all* file names internally. > All conversions UTF-8 <-> path must be explicit (via the mapper > library), and all uses for system calls must be reviewed. There is no > added overhead here. > Once that is complete, you can change the storage of that class from > char to wchar_t for WIN32, and the compiler will help you spot the > code locations that must be converted to wchar_t system calls. Storage class for what? For protocol FileName (which is always UTF-8 anyway)? Or for real file names which you want to keep as char*? If second this would introduce pre-processor weirdness in the code that uses stdio and friends because each such call would require #ifdef. -- Denis ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
